Skip to content

Conversation

@danielerez
Copy link
Contributor

When EnableInteractiveFlow is enabled, configure registry mirrors and oc-mirror output to use localhost instead of the default registry domain. This is needed to avoid any suprious entries in registries.conf file.

Changes:

  • Update generateRegistries to accept enableInteractiveFlow parameter
  • Use localhost when interactive flow is enabled for registry mirrors
  • Update copyOutputYamls to use localhost registry domain in interactive flow
  • Add swag import for boolean value handling

When EnableInteractiveFlow is enabled, configure registry mirrors and
oc-mirror output to use localhost instead of the default registry domain.
This is needed to avoid any suprious entries in registries.conf file.

Changes:
- Update generateRegistries to accept enableInteractiveFlow parameter
- Use localhost when interactive flow is enabled for registry mirrors
- Update copyOutputYamls to use localhost registry domain in interactive flow
- Add swag import for boolean value handling
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2026

@danielerez: This pull request references AGENT-1426 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

When EnableInteractiveFlow is enabled, configure registry mirrors and oc-mirror output to use localhost instead of the default registry domain. This is needed to avoid any suprious entries in registries.conf file.

Changes:

  • Update generateRegistries to accept enableInteractiveFlow parameter
  • Use localhost when interactive flow is enabled for registry mirrors
  • Update copyOutputYamls to use localhost registry domain in interactive flow
  • Add swag import for boolean value handling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gamli75 and jhernand January 28, 2026 09:52
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@danielerez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-compact-ipv4-static 8dc40fc link true /test e2e-compact-ipv4-static
ci/prow/unit-test 8dc40fc link true /test unit-test
ci/prow/e2e-sno-dualstack-dhcp 8dc40fc link false /test e2e-sno-dualstack-dhcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants