Added filtering functionality to subscription creation#16
Open
andersong-precisionOT wants to merge 3 commits intoopenshift-telco:mainfrom
Open
Added filtering functionality to subscription creation#16andersong-precisionOT wants to merge 3 commits intoopenshift-telco:mainfrom
andersong-precisionOT wants to merge 3 commits intoopenshift-telco:mainfrom
Conversation
Filtered stream added to operations.go
Filter options added to notification.go
Contributor
|
Hi @andersong-precisionOT thank you for the contribution. Instead of duplicating the functions, can you parameterize the existing one? Thanks |
Author
Just pushed this. Only reason it wasn't implemented like this to begin with was concerns with backwards compatibility. |
Contributor
|
@hanengarcia can you merge this please? |
adetalhouet
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added:
CreateNotificationStreamFiltered()
NewCreateSubscriptionFiltered()
Filter field to struct CreateSubscriptionData
Filters are passed in as a string to the CreateNotificationStreamFiltered function.
The string should have no newlines and be in XML format, containing the filter tag and all desired components inside of it.
Ex.
filter := "<filter><severity>critical</severity></filter>"Filtering otherwise follows standard NETCONF rules
Addresses issue #13