Use typed context keys for txid and opid #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafabene
force-pushed
the
feature/typed-context-key-txid
branch
from
31ad72c to
10dbf0a
Compare
Replace string literal context keys with typed keys to improve type safety and prevent potential key collisions. This follows Go best practices for context value keys. Changes: - Add txIDKeyType and TxIDKey for transaction ID context storage - Update OpIDKey value to use snake_case (op_id) for consistency - Update logger to use TxIDKey instead of string literal
rafabene
force-pushed
the
feature/typed-context-key-txid
branch
from
10dbf0a to
7fb782e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TransactionIDKeyandTxIDKeyfor transaction ID context storageOpIDKeyvalue to use snake_case (op_id) for consistencyTxIDKeyinstead of string literalThis follows Go best practices for context value keys and maintains consistency between snake_case and camelCase naming conventions across the codebase.
Test plan
go build ./...)