-
Notifications
You must be signed in to change notification settings - Fork 150
Update go version and dependencies. #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bergmannf The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughUpdated Go module dependencies in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
Comment |
fbc19e5 to
ee1e4cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
🔇 Additional comments (2)
go.mod (2)
3-3: Go version 1.24.6 is valid and includes security fixes.Go 1.24.6 includes security fixes to the database/sql and os/exec packages, aligning with the PR objective to fix recent CVEs. This is a reasonable update for addressing security vulnerabilities in the Go standard library.
5-34: Dependency updates are safe to proceed—no deprecated APIs are used in the codebase.While the flagged dependency versions (cobra v1.10.2, grpc v1.77.0, k8s.io/apimachinery v0.34.3) contain documented breaking changes, verification confirms the codebase does not invoke any of the affected APIs:
- No grpc.Dial/DialContext calls
- No ParseErrorsWhitelist usage
- No problematic JSON int operations
- All dependencies resolve cleanly
The build succeeds and integration tests can proceed without concern for these specific breaking changes.
This should fix recent CVEs in the used libraries.
ee1e4cb to
4f72045
Compare
This should fix recent CVEs in the libraries & stdlib in use by the CLI.