Update account nav button style when nav group home enabled#2279
Update account nav button style when nav group home enabled#2279wanglam wants to merge 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
=======================================
Coverage 71.96% 71.96%
=======================================
Files 98 98
Lines 2679 2679
Branches 417 409 -8
=======================================
Hits 1928 1928
Misses 637 637
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
| <EuiButtonEmpty | ||
| size="xs" | ||
| flush="both" | ||
| className="accountNavButton" |
There was a problem hiding this comment.
Since we are removing this className in the the new component, should we also remove its scss file - public/apps/account/account-nav-button.scss? Or do we need to apply the same styling to this new component?
There was a problem hiding this comment.
Thanks for catching that. I think we should remove this scss file if we don't need this className anymore. Let me do some investigation to confirm this.
Signed-off-by: Lin Wang <wonglam@amazon.com>
|
Hi @RyanL1997, Thanks for reviewing my PR. We have some differing decisions on the left navigation changes. We may need to revert all the left navigation changes today. I will convert this PR to draft and may close this PR. |
|
@wanglam Do you intend to continue working on this PR? |
Description
Update account nav button style when nav group home enabled, the new look & feel should like screenshot below:


Category
Enhancement
Why these changes are required?
The OSD PR refactor the left navigation footer and target to released in opensearch 3.2.0. The account nav button UI should be update according the newest design.
What is the old behavior before changes and new behavior after changes?
Only UI changes, the old behavior like below:

Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.