[Backport 2.x] Fixes saml login flow to work with anonymous auth#1887
Merged
[Backport 2.x] Fixes saml login flow to work with anonymous auth#1887
Conversation
* Fixes anonymous auth flow to work with SAML Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds hardcoded credentials for anonymous user Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Updates basic auth header to be a config constant Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Removes unneeded usage of anonymous auth header constant Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Updates logic to display anonymous auth login button Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds test to check whether anonymous auth login button is displayed correctly Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes integrationtests Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds integration tests for anonymous auth login with basic authorization header Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Generates random password for anonymous user Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes lint errors Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds saml auth header to differentiate saml requests Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes linter errors Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes basic auth tests Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Removes console loggers Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes lint error Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Addresses feedback Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Resolves #1840 Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Replace magic value with constant Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Renames query param and removes unused variables Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Uses enum instead of magic constant Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Extracts template function to a separate util file Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Renames test Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Removes unnecessary modifications required to solve this bug Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes import Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Removes unused param Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Removes unused method param Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Removes incorrect method param Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 681d1b1)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1887 +/- ##
==========================================
+ Coverage 67.94% 68.07% +0.12%
==========================================
Files 93 93
Lines 2365 2365
Branches 323 323
==========================================
+ Hits 1607 1610 +3
+ Misses 681 679 -2
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. |
derek-ho
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 681d1b1 from #1839