Skip to content

[Backport 3.1] Remove correlated findings bar chart that uses vega #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opensearch-trigger-bot wants to merge 1 commit into
base: 3.1
Choose a base branch
from
Open

[Backport 3.1] Remove correlated findings bar chart that uses vega #1314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 2 additions & 60 deletions public/pages/Correlations/containers/CorrelationsTableView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,8 @@
* SPDX-License-Identifier: Apache-2.0
*/
import React from 'react';
import {
EuiLoadingChart,
EuiPanel,
EuiFlexGroup,
EuiFlexItem,
EuiTitle,
EuiSpacer,
EuiEmptyPrompt,
EuiSmallButton,
EuiText,
} from '@elastic/eui';
import { ChartContainer } from '../../../components/Charts/ChartContainer';
import { EuiLoadingChart } from '@elastic/eui';
import { DEFAULT_DATE_RANGE, ROUTES } from '../../../utils/constants';
import { renderVisualization } from '../../../utils/helpers';
import { getChartTimeUnit, getDomainRange } from '../../Overview/utils/helpers';
import { getCorrelatedFindingsVisualizationSpec } from '../utils/helpers';
import { CorrelationsTableData } from './CorrelationsContainer';
Expand Down Expand Up @@ -157,52 +145,6 @@ export class CorrelationsTableView extends React.Component<
);
};

private renderCorrelatedFindingsChart = () => {
renderVisualization(
this.generateVisualizationSpec(this.props.connectedFindings),
'correlated-findings-view'
);
return this.props.connectedFindings.length > 0 ? (
<>
<EuiPanel>
<EuiFlexGroup direction="column" gutterSize="m">
<EuiFlexItem>
<EuiFlexGroup justifyContent="spaceBetween">
<EuiFlexItem grow={false}>
<EuiTitle size="s">
<h3>Correlated Findings</h3>
</EuiTitle>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
<EuiFlexItem>
<ChartContainer chartViewId="correlated-findings-view" />
</EuiFlexItem>
</EuiFlexGroup>
</EuiPanel>
<EuiSpacer />
</>
) : (
<EuiEmptyPrompt
title={
<EuiText size="s">
<h2>No correlations found</h2>
</EuiText>
}
body={
<EuiText size="s">
<p>There are no correlated findings in the system.</p>
</EuiText>
}
actions={[
<EuiSmallButton fill={true} color="primary" href={`#${ROUTES.CORRELATION_RULE_CREATE}`}>
Create correlation rule
</EuiSmallButton>,
]}
/>
);
};

private getFilteredTableData = (tableData: CorrelationsTableData[]): CorrelationsTableData[] => {
const { logTypeFilterOptions, severityFilterOptions, searchTerm } = this.props;
const alertSeverityMap: { [key: string]: string } = {
Expand Down Expand Up @@ -284,7 +226,7 @@ export class CorrelationsTableView extends React.Component<
render() {
return (
<>
{this.renderCorrelatedFindingsChart()}
{/* {this.renderCorrelatedFindingsChart()} */}
{this.renderCorrelationsTable(this.props.loadingTableData)}
{this.state.isFlyoutOpen && (
<CorrelationsTableFlyout
Expand Down
Loading