[Part 1] Fixed lint errors#1225
Open
amsiglan wants to merge 2 commits intoopensearch-project:mainfrom
Open
Conversation
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
riysaxen-amzn and
sbcd90
as code owners
amsiglan
force-pushed
the
fix-lint-errors-part-1
branch
from
0202b63 to
45370b6
Compare
amsiglan
commented
Dec 3, 2024
Collaborator
Author
There was a problem hiding this comment.
Deleting this because we should use the core config
AWSHurneyt
approved these changes
Dec 3, 2024
amsiglan
force-pushed
the
fix-lint-errors-part-1
branch
from
45370b6 to
5a68b20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently linter check is not running as part of CI and enabling that would require step by step fixing all the files once
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.