PR7: feat: component SCSS enhancements for v9 theme support#1701
Open
anirudha wants to merge 2 commits intoopensearch-project:mainfrom
Open
PR7: feat: component SCSS enhancements for v9 theme support#1701anirudha wants to merge 2 commits intoopensearch-project:mainfrom
anirudha wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Enhance component SCSS files to consume new v9 theme variables while maintaining backward compatibility with existing themes (oui, oui-next). Components updated: - side_nav: Major rework with configurable border radius, hover/active states, selected accent bar, and branch line styling - toast: Modern v9 styling with accent bar, close button hover effects, and configurable animations with reduced motion support - datagrid: Border radius, shadow, and hover state enhancements - badge: Icon spacing with gap, hover transform effects - form_control_layout: Border radius management for grouped form controls with proper clipping for nested layouts - list_group: Variable updates - button_group: Minor fix - charts theme: Minor fix All changes use @if variable-exists() guards to conditionally apply v9 styling only when v9 theme variables are present, ensuring zero impact on existing themes. Signed-off-by: Anirudha Jadhav <anirudha@nyu.edu> Signed-off-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
anirudha
requested review from
AMoo-Miki,
Maosaic,
angle943,
ashwin-pc,
d-buckner,
ruanyl,
ruchidh and
virajsanghvi
as code owners
Signed-off-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance component SCSS files to consume new v9 theme variables while maintaining backward compatibility with existing themes (oui, oui-next).
Components updated:
All changes use @if variable-exists() guards to conditionally apply v9 styling only when v9 theme variables are present, ensuring zero impact on existing themes.
PR 7: Component SCSS Enhancements (~10 files)
Scope: Larger component SCSS changes that consume the new variables from PR 3 and PR 6 — primarily side_nav, toast, datagrid, badge, and form_control_layout.
Files included:
src/components/side_nav/_side_nav_item.scss(major rework)src/components/toast/_toast.scss(major rework)src/components/toast/_global_toast_list.scss(enhancements)src/components/datagrid/_data_grid.scss(enhancements)src/components/datagrid/_data_grid_data_row.scss(enhancements)src/components/datagrid/_data_grid_header_row.scss(enhancements)src/components/badge/_badge.scss(enhancements)src/components/badge/beta_badge/_beta_badge.scsssrc/components/badge/notification_badge/_notification_badge.scsssrc/components/form/form_control_layout/_form_control_layout.scss(major additions)src/components/list_group/_variables.scsssrc/components/button/button_group/_button_group_button.scsssrc/themes/charts/theme.scss(minor fix)Testing:
yarn test-unit side_nav toast datagrid badge form_control_layoutfor snapshot updates,yarn lint, fullyarn test-unitfor regression check