PR6: feat: add v9 component variables and style overrides#1700
Open
anirudha wants to merge 2 commits intoopensearch-project:mainfrom
Open
PR6: feat: add v9 component variables and style overrides#1700anirudha wants to merge 2 commits intoopensearch-project:mainfrom
anirudha wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Add v9-specific variable files for component styling: - badge, data_grid, filter_group, side_nav, toast variables - Updates to animations, borders, buttons, colors, form, header, states Add v9 component style overrides: - breadcrumbs, call_out, data_grid, filter_button, filter_group - link, list_group, selectable, toast Update elevation CSS variables and shadow mixins for v9 theme. Signed-off-by: Anirudha Jadhav <anirudha@nyu.edu> Signed-off-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
anirudha
requested review from
AMoo-Miki,
Maosaic,
angle943,
ashwin-pc,
d-buckner,
ruanyl,
ruchidh and
virajsanghvi
as code owners
Signed-off-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add v9-specific variable files for component styling:
Add v9 component style overrides:
Update elevation CSS variables and shadow mixins for v9 theme.
PR 6: V9 Component Variables + Style Overrides (~25 files)
Scope: V9-specific variable files and component style overrides that customize component appearance under the v9 theme.
Files included:
src/themes/v9/global_styling/variables/_badge.scsssrc/themes/v9/global_styling/variables/_data_grid.scsssrc/themes/v9/global_styling/variables/_filter_group.scsssrc/themes/v9/global_styling/variables/_side_nav.scsssrc/themes/v9/global_styling/variables/_toast.scsssrc/themes/v9/global_styling/variables/_animations.scss(additions)src/themes/v9/global_styling/variables/_borders.scss(updates)src/themes/v9/global_styling/variables/_buttons.scss(additions)src/themes/v9/global_styling/variables/_colors.scss(updates)src/themes/v9/global_styling/variables/_form.scss(updates)src/themes/v9/global_styling/variables/_header.scss(updates)src/themes/v9/global_styling/variables/_states.scss(updates)src/themes/v9/global_styling/variables/_index.scss(imports)src/themes/v9/components/(all 10 override files + _index.scss)Testing:
yarn lint, v9 theme entry points compile, visual verification of overridden components