PR3: feat: cross-theme variable defaults for badge, filter_group, side_nav…#1697
Open
anirudha wants to merge 2 commits intoopensearch-project:mainfrom
Open
PR3: feat: cross-theme variable defaults for badge, filter_group, side_nav…#1697anirudha wants to merge 2 commits intoopensearch-project:mainfrom
anirudha wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
…, animations, typography Signed-off-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
anirudha
requested review from
AMoo-Miki,
Maosaic,
angle943,
ashwin-pc,
d-buckner,
ruanyl,
ruchidh and
virajsanghvi
as code owners
Signed-off-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, animations, typography
PR Plan : #1695
Scope: Add new
!defaultvariable files tosrc/global_styling/variables/and mirror them insrc/themes/oui-next/global_styling/variables/. These provide default values that the v9 theme (and future themes) can override.Files included:
src/global_styling/variables/_badge.scss(new)src/global_styling/variables/_filter_group.scss(new)src/global_styling/variables/_side_nav.scss(new)src/global_styling/variables/_animations.scss(additions)src/global_styling/variables/_typography.scss(additions)src/global_styling/variables/_index.scss(import additions)src/themes/oui-next/global_styling/variables/Testing:
yarn lint,yarn test-unit— existing themes compile and all existing tests pass