debian package: fix installation issues on systems having systemd installed but not running it as init.#4242
Open
automaticserver wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
…talled but not running it as init.
Instead of checking for the existence of systemd binaries check for actually running systemd,
as seen by the reference result when using dh_installsystemd:
\# Automatically added by dh_installsystemd/13.11.4
if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = upgrade ] && [ -d /run/systemd/system ] ; then
deb-systemd-invoke stop 'opensearch.service' >/dev/null || true
fi
\# End automatically added section
automaticserver
requested review from
Divyaasm,
bbarani,
dblock,
gaiksaya,
jordarlu,
peterzhuamazon,
prudhvigodithi,
rishabh6788,
tianleh and
zelinh
as code owners
Author
|
As announced see also #4243 to decide whether to keep this PR open or not. /dm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4242 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 189 189
Lines 5973 5973
=======================================
Hits 5565 5565
Misses 408 408 ☔ View full report in Codecov by Sentry. |
prudhvigodithi
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of checking for the existence of systemd binaries check for actually running systemd, as seen by the reference result when using dh_installsystemd:
This is only a fix based on the current implementation. I'm not changing the way systemctl is invoked.
Issues Resolved
This PR can be rejected if my upcoming proposal issue is considered (will post link below as comment once created)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
/dm