[Maintainence]Added security test#596
Open
sumukhswamy wants to merge 9 commits intoopensearch-project:mainfrom
Open
[Maintainence]Added security test#596sumukhswamy wants to merge 9 commits intoopensearch-project:mainfrom
sumukhswamy wants to merge 9 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
This reverts commit 1cd17ec.
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 71.02% 70.99% -0.03%
==========================================
Files 31 31
Lines 2074 2072 -2
Branches 464 459 -5
==========================================
- Hits 1473 1471 -2
Misses 595 595
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Member
|
@sumukhswamy the tests will fail in this PR until all relevant code is open-sourced. Can you please contribute the code to security and common-utils repos? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Cypress test verifies that an internal user with the reports_full_access role can be created, assigned the correct permissions, and mapped to the role in a security-enabled OpenSearch Dashboards environment. The test is especially relevant due to a regression introduced in OpenSearch 2.19, where a refactor of the PrivilegesEvaluator class in the security plugin removed the logic for setting or reading the requestTenantAccess field. This field is critical for the reporting plugin to determine which tenants a user can access. Without it, the reporting plugin receives a null value and denies access to reporting features, even for users who should have permission. This test helps ensure that user and role setup works as expected and highlights the impact of the missing requestTenantAccess logic on reporting access.
====================================================================================================
(Run Finished)
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ 01-create.spec.ts 01:55 15 15 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ 02-edit.spec.ts 01:20 3 3 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ 03-details.spec.ts 00:31 6 6 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ 04-download.spec.ts 00:50 5 5 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ 05-security.spec.ts 00:16 4 3 - 1 - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! 04:53 33 32 - 1 -
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.