Open
Conversation
Signed-off-by: Jay Pelletier <jpelletier@titaniumplatform.com> Signed-off-by: Jay Pelletier <143456153+jpelletier412@users.noreply.github.com>
tfidecki
approved these changes
Apr 29, 2025
|
We had the same issue with the Reporting plugin on system with IPv6. We had to modify the file server/routes/reportDefinition.ts and server/routes/report.ts by replacing: by |
|
Hi, this issue impacts us too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where an error is thrown when attempting to create a report definition when using IPv6 hostname. Validation of the create definition URL fails because no square brackets are around the hostname when also defining a port.
If server.host is set to "::", the URL is then constructed as "https://:::5601/". This is not a valid IPv6 URL and should be "https://[::]:5601/".
The fix is to add those brackets around the hostname when dealing with an IPv6 hostname.
Issues Resolved
#490
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.