Construct dummy request for doc level monitor fanout request on serde failure #806#807
Open
eirsep wants to merge 7 commits intoopensearch-project:mainfrom
Open
Construct dummy request for doc level monitor fanout request on serde failure #806#807eirsep wants to merge 7 commits intoopensearch-project:mainfrom
eirsep wants to merge 7 commits intoopensearch-project:mainfrom
Conversation
eirsep
requested review from
AWSHurneyt,
bowenlan-amzn,
engechas,
getsaurabh02,
jowg-amazon,
lezzago,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
… failure Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
force-pushed
the
serde_fix
branch
2 times, most recently
from
f0a7d8a to
19a6af8
Compare
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
sbcd90
previously approved these changes
Mar 24, 2025
AWSHurneyt
previously approved these changes
Mar 24, 2025
engechas
reviewed
Mar 24, 2025
| sin.readBoolean() | ||
| } catch (e: Exception) { | ||
| log.error("Error parsing boolean in Doc level monitor fanout request", e) | ||
| false |
Collaborator
There was a problem hiding this comment.
How does it affect execution if we end up with the default value for these fields? It seems like we need some way to signal that the fanout should not execute if we encounter a deserialization error like this
Member
Author
There was a problem hiding this comment.
we are not gonna use these fields. the alerting plugin will look for null check on index execution context opensearch-project/alerting#1815
Member
Author
There was a problem hiding this comment.
added a flag to indicate serialization failed if any of the safeRead*() methods fail
riysaxen-amzn
previously approved these changes
Mar 24, 2025
…n out request Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
dismissed stale reviews from riysaxen-amzn, AWSHurneyt, and sbcd90
via
d30dac5
engechas
previously approved these changes
Mar 25, 2025
| concreteIndicesSeenSoFar: List<String>, | ||
| workflowRunContext: WorkflowRunContext? | ||
| workflowRunContext: WorkflowRunContext?, | ||
| hasSerializationFailed: Boolean? = null |
Collaborator
There was a problem hiding this comment.
Should this be passable via a constructor?
| } | ||
| } | ||
| return indexExecutionContext | ||
| } catch (e: EOFException) { |
Collaborator
There was a problem hiding this comment.
Should we set serializationFailedFlag = true in this catch as well?
sbcd90
previously approved these changes
Mar 25, 2025
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
AWSHurneyt
previously approved these changes
Mar 25, 2025
…t for Doc Level monitor fanout request Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
| // read and discard bytes until stream is entirely consumed | ||
| try { | ||
| sin.readByte() | ||
| } catch (_: EOFException) { |
Collaborator
There was a problem hiding this comment.
should we log here as well?
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
riysaxen-amzn
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to handle failures in doc level monitor fanout request construction during upgrades when nodes from old and new versions co-exist we create a dummy request if serde fails.
This situation occurs as new fields have been added without version check in monitor object which causes serde failures when doc level monitor execution starts on a node in older version and fans out to a node on a newer version with different serialization code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.