Run precommit before gradle check

[owaiskazi19]

Signed-off-by: Owais Kazi owaiskazi19@gmail.com

Description

This PR adds dependency of precommit to run successfully before running gradle check. Thus saving time and collecting errors before waiting for the entire gradle check suite to run.

Dependency chart: spotless -> precommit -> gradle check

For more information: #5027 and #4679

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/6324/
• CommitID: 5b8d80a
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/6325/
• CommitID: 1bd2feb
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

distribution: temurin please

[owaiskazi19]

I copy/pasted precommit from main which has adopt distribution. Updated it.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6414/
• CommitID: 1bd2feb

[codecov-commenter]

Codecov Report

Merging #5066 (1bd2feb) into main (fab4336) will decrease coverage by 0.00%.
The diff coverage is 61.93%.

@@             Coverage Diff              @@
##               main    #5066      +/-   ##
============================================
- Coverage     70.84%   70.83%   -0.01%     
- Complexity    57867    58076     +209     
============================================
  Files          4692     4704      +12     
  Lines        276650   277309     +659     
  Branches      40155    40170      +15     
============================================
+ Hits         196002   196444     +442     
- Misses        64500    64765     +265     
+ Partials      16148    16100      -48     

Impacted Files	Coverage Δ
...java/org/opensearch/upgrade/ValidateInputTask.java	84.61% <0.00%> (ø)
...ch/analysis/common/CommonAnalysisModulePlugin.java	92.33% <0.00%> (+0.05%)	⬆️
.../src/main/java/org/opensearch/LegacyESVersion.java	59.34% <ø> (-2.37%)	⬇️
...ecommission/awareness/put/DecommissionRequest.java	85.71% <0.00%> (-6.60%)	⬇️
...min/cluster/stats/TransportClusterStatsAction.java	70.83% <ø> (ø)
...ensearch/action/search/SearchTransportService.java	86.80% <ø> (-0.20%)	⬇️
...va/org/opensearch/action/update/UpdateRequest.java	47.35% <0.00%> (+2.90%)	⬆️
...arch/cluster/decommission/DecommissionService.java	35.65% <0.00%> (+0.38%)	⬆️
.../cluster/metadata/IndexNameExpressionResolver.java	83.79% <ø> (-0.03%)	⬇️
...va/org/opensearch/cluster/node/DiscoveryNodes.java	89.72% <ø> (-0.18%)	⬇️
... and 592 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6455/
• CommitID: f29ae69

[dblock]

Change the JDK distribution to keep it consistent.

[owaiskazi19]

Github Action worked fine on my fork.
The sequence was spotless -> precommit -> gradle check. Not sure why it's not working the same way here.
cc: @reta @peterzhuamazon

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/6481/
• CommitID: 0e309b5
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6484/
• CommitID: 0e309b5

[reta]

Github Action worked fine on my fork. The sequence was spotless -> precommit -> gradle check. Not sure why it's not working the same way here. cc: @reta @peterzhuamazon

Hm .. it seems like the Github actions are being taken from main branch, may be because the branch is protected? (and it is not in your fork)

[peterzhuamazon]

This PR has caused a lot of issue and is not even checking out the correct commit to run spotless and gradle precommit:
See:

• Bump nebula-publishing-plugin from v4.4.0 to v4.6.0. #5127 (comment)

[owaiskazi19]

This PR has caused a lot of issue and is not even checking out the correct commit to run spotless and gradle precommit: See:

• Bump nebula-publishing-plugin from v4.4.0 to v4.6.0. #5127 (comment)

We were under the impression it's because of the branch protection rule. What are the correct commits to run spotless and precommit @peterzhuamazon ?