Awareness attribute decommission backports#4970
Merged
Bukhtawar merged 11 commits intoopensearch-project:2.xfrom Nov 2, 2022
Merged
Awareness attribute decommission backports#4970Bukhtawar merged 11 commits intoopensearch-project:2.xfrom
Bukhtawar merged 11 commits intoopensearch-project:2.xfrom
Conversation
…ommissioning (opensearch-project#4084) * Add Executor to decommission node attribute * Decommission service implementation with cluster metadata * Master abdication changes to decommission local awareness leader * Update join validator changes to validate decommissioned node join request Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…oject#4261) * Add APIs (GET/PUT) to decommission awareness attribute Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* Recommission API service level changes Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* Add changes for Recommission API Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* Controlling discovery for decommissioned nodes Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…t#4800) * Fix decommission status update to non leader nodes Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…project#4751) * Add attribute name to query param and simplify GetDecommissionStateResponse Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* Fix bug in AwarenessAttributeDecommissionIT Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4970 +/- ##
==========================================
Coverage 70.65% 70.66%
- Complexity 57658 57829 +171
==========================================
Files 4620 4645 +25
Lines 276220 276891 +671
Branches 40422 40490 +68
==========================================
+ Hits 195171 195671 +500
- Misses 64771 64894 +123
- Partials 16278 16326 +48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bukhtawar
reviewed
Nov 2, 2022
| @Override | ||
| public Version getMinimalSupportedVersion() { | ||
| return Version.V_3_0_0; | ||
| return Version.V_2_4_0; |
Contributor
There was a problem hiding this comment.
Is this the only place we have versioning enabled? What happens to clusters running mixed version 2.0 and 2.4 lets say
Member
Author
There was a problem hiding this comment.
Two more places -
DECOMMISSIONING_FAILED_EXCEPTION(
org.opensearch.cluster.decommission.DecommissioningFailedException.class,
org.opensearch.cluster.decommission.DecommissioningFailedException::new,
163,
V_2_4_0
),
NODE_DECOMMISSIONED_EXCEPTION(
org.opensearch.cluster.decommission.NodeDecommissionedException.class,
org.opensearch.cluster.decommission.NodeDecommissionedException::new,
164,
V_2_4_0
);
6 tasks
Bukhtawar
approved these changes
Nov 2, 2022
imRishN
added a commit
to imRishN/OpenSearch
that referenced
this pull request
Nov 3, 2022
* Add DecommissionService and helper to execute awareness attribute decommissioning opensearch-project#4084 * Add APIs (GET/PUT) to decommission awareness attribute opensearch-project#4261 * Controlling discovery for decommissioned nodes opensearch-project#4590 * Fix decommission status update to non leader nodes opensearch-project#4800 * Remove redundant field from GetDecommissionStateResponse opensearch-project#4751 * Service Layer changes for Recommission API opensearch-project#4320 * Recommission api level support opensearch-project#4604 * Fix bug in AwarenessAttributeDecommissionIT opensearch-project#4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
imRishN
added a commit
to imRishN/OpenSearch
that referenced
this pull request
Nov 3, 2022
* Add DecommissionService and helper to execute awareness attribute decommissioning opensearch-project#4084 * Add APIs (GET/PUT) to decommission awareness attribute opensearch-project#4261 * Controlling discovery for decommissioned nodes opensearch-project#4590 * Fix decommission status update to non leader nodes opensearch-project#4800 * Remove redundant field from GetDecommissionStateResponse opensearch-project#4751 * Service Layer changes for Recommission API opensearch-project#4320 * Recommission api level support opensearch-project#4604 * Fix bug in AwarenessAttributeDecommissionIT opensearch-project#4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
6 tasks
Bukhtawar
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Awareness attribute decommission backports (#4970) * Add DecommissionService and helper to execute awareness attribute decommissioning #4084 * Add APIs (GET/PUT) to decommission awareness attribute #4261 * Controlling discovery for decommissioned nodes #4590 * Fix decommission status update to non leader nodes #4800 * Remove redundant field from GetDecommissionStateResponse #4751 * Service Layer changes for Recommission API #4320 * Recommission api level support #4604 * Fix bug in AwarenessAttributeDecommissionIT #4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports following PRs from Decommission Project -
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.