REST API Layer changes for recommission support by pranikum · Pull Request #4321 · opensearch-project/OpenSearch

pranikum · 2022-08-29T14:37:13Z

Signed-off-by: pranikum 109206473+pranikum@users.noreply.github.com

Description

This change contain REST API layer changes for Recommission API support.
This pr is dependent of Service layer changes. (#4320)

This change has some changes for the PR #4084

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-08-29T14:44:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2191/
CommitID: 84a8d44

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-01T12:49:25Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2424/
CommitID: 73c55bc

imRishN · 2022-09-02T08:00:37Z

Changes to -

client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientTests.java
rest-api-spec/src/main/resources/rest-api-spec/api
are missing. We need to add that

...opensearch/action/admin/cluster/decommission/awareness/delete/DeleteDecommissionRequest.java

...ch/action/admin/cluster/decommission/awareness/delete/TransportDeleteDecommissionAction.java

server/src/main/java/org/opensearch/client/ClusterAdminClient.java

server/src/main/java/org/opensearch/cluster/decommission/DecommissionAttribute.java

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-07T05:03:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2797/
CommitID: 88ed486

github-actions · 2022-09-07T05:51:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2799/
CommitID: b60379f

github-actions · 2022-09-07T05:55:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2800/
CommitID: 02a3d30

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-20T14:39:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3248/
CommitID: 20aab7c

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-20T15:55:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3256/
CommitID: 6abea15

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-20T16:47:55Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3263/
CommitID: c70f990

github-actions · 2022-09-20T16:59:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3266/
CommitID: 89eff69

codecov-commenter · 2022-09-20T17:01:30Z

Codecov Report

Merging #4321 (7312b41) into main (57a4aed) will decrease coverage by 0.17%.
The diff coverage is 65.24%.

@@             Coverage Diff              @@
##               main    #4321      +/-   ##
============================================
- Coverage     70.81%   70.64%   -0.18%     
+ Complexity    57438    57426      -12     
============================================
  Files          4617     4634      +17     
  Lines        275545   276114     +569     
  Branches      40340    40421      +81     
============================================
- Hits         195125   195050      -75     
- Misses        64085    64743     +658     
+ Partials      16335    16321      -14

Impacted Files	Coverage Δ
...va/org/opensearch/geometry/GeometryCollection.java	`96.42% <0.00%> (+0.13%)`	⬆️
...le/customsettings/ExampleCustomSettingsConfig.java	`29.03% <ø> (ø)`
...le/customsettings/ExampleCustomSettingsPlugin.java	`9.09% <ø> (ø)`
...igheuristic/CustomSignificanceHeuristicPlugin.java	`0.00% <0.00%> (ø)`
...ch/example/customsigheuristic/SimpleHeuristic.java	`86.66% <ø> (ø)`
...earch/example/customsuggester/CustomSuggester.java	`0.00% <0.00%> (ø)`
...example/customsuggester/CustomSuggesterPlugin.java	`0.00% <0.00%> (ø)`
...arch/example/customsuggester/CustomSuggestion.java	`0.00% <ø> (ø)`
...ample/customsuggester/CustomSuggestionBuilder.java	`0.00% <ø> (ø)`
...ample/customsuggester/CustomSuggestionContext.java	`0.00% <ø> (ø)`
... and 541 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

.../opensearch/action/admin/cluster/decommission/awareness/delete/DeleteDecommissionAction.java

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-22T12:03:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3313/
CommitID: 86f8c54

imRishN · 2022-09-22T12:03:59Z

server/src/main/java/org/opensearch/client/ClusterAdminClient.java

+     * Deletes the decommission metadata.
+     */
+    ActionFuture<DeleteDecommissionStateResponse> deleteDecommission(DeleteDecommissionStateRequest request);
+
+    /**
+     * Deletes the decommission metadata.
+     */
+    void deleteDecommission(DeleteDecommissionStateRequest request, ActionListener<DeleteDecommissionStateResponse> listener);
+
+    /**
+     * Deletes the decommission metadata.
+     */
+    DeleteDecommissionStateRequestBuilder prepareDeleteDecommission();


nit: deleteDecommissionState

imRishN · 2022-09-22T12:04:31Z

server/src/main/java/org/opensearch/client/Requests.java

+    /**
+     * Creates a new delete decommission request.
+     */
+    public static DeleteDecommissionStateRequest deleteDecommissionRequest() {


nit: deleteDecommissionStateRequest

github-actions · 2022-09-22T12:15:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3314/
CommitID: 24ab026

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-22T12:34:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3315/
CommitID: 3bcda1a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-22T13:04:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3318/
CommitID: 7312b41

pranikum · 2022-09-27T09:13:44Z

Closing this PR. Reopened another one.

#4604

Add rest api changes

84a8d44

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum requested review from a team and reta as code owners August 29, 2022 14:37

pranikum mentioned this pull request Aug 31, 2022

Service Layer changes for Recommission API #4320

Merged

6 tasks

pranikum added 3 commits September 1, 2022 14:06

Merge branch 'main' into recommission-api-level-support

01e277a

Remove attribute for Delete decommission

9af0231

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Fix tests

73c55bc

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

imRishN reviewed Sep 2, 2022

View reviewed changes

pranikum added 4 commits September 7, 2022 08:51

Merge branch 'main' into recommission-api-level-support

93d662d

Add Tests. Spotless fix

88ed486

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge with Main

aef6a79

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge branch 'main' into recommission-api-level-support

76e6d01

pranikum added 2 commits September 7, 2022 11:13

Merge with main

b60379f

Add EOL for json file

02a3d30

pranikum added 3 commits September 20, 2022 18:15

Take changelog from latest

d153129

Merge branch 'main' into recommission-api-level-support

5acf777

PR comments.

20aab7c

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Fix test cases

6abea15

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 2 commits September 20, 2022 21:35

Add javadoc

c70f990

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Add package info

89eff69

imRishN reviewed Sep 22, 2022

View reviewed changes

.../opensearch/action/admin/cluster/decommission/awareness/delete/DeleteDecommissionAction.java Outdated Show resolved Hide resolved

pranikum added 2 commits September 22, 2022 17:06

Rename class DeleteDecommissionStateAction

86f8c54

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Rename Class

24ab026

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

imRishN approved these changes Sep 22, 2022

View reviewed changes

Update method name

3bcda1a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Spotless Java check

7312b41

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum mentioned this pull request Sep 27, 2022

Recommission api level support #4604

Merged

6 tasks

pranikum closed this Sep 27, 2022

pranikum deleted the recommission-api-level-support branch July 17, 2025 03:12

Conversation

pranikum commented Aug 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Aug 29, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 1, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

imRishN commented Sep 2, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov-commenter commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Sep 22, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

imRishN Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

pranikum Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

imRishN Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

pranikum Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 22, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 22, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 22, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

pranikum commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pranikum commented Aug 29, 2022 •

edited

Loading

codecov-commenter commented Sep 20, 2022 •

edited

Loading