Update Subject interface to use CheckedRunnable#18570
Merged
cwperks merged 5 commits intoopensearch-project:mainfrom Jun 21, 2025
Merged
Update Subject interface to use CheckedRunnable#18570cwperks merged 5 commits intoopensearch-project:mainfrom
cwperks merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
|
❌ Gradle check result for b84ec51: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18570 +/- ##
============================================
+ Coverage 72.68% 72.76% +0.07%
- Complexity 68130 68145 +15
============================================
Files 5540 5540
Lines 313379 313382 +3
Branches 45472 45472
============================================
+ Hits 227785 228023 +238
+ Misses 67070 66754 -316
- Partials 18524 18605 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
reviewed
Jun 20, 2025
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
andrross
approved these changes
Jun 20, 2025
5 tasks
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…8570) * Update Subject interface to use CheckedRunnable Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update more instances Signed-off-by: Craig Perkins <cwperx@amazon.com> * Mark with PublicApi Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update javadoc Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…8570) * Update Subject interface to use CheckedRunnable Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update more instances Signed-off-by: Craig Perkins <cwperx@amazon.com> * Mark with PublicApi Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update javadoc Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
…8570) * Update Subject interface to use CheckedRunnable Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update more instances Signed-off-by: Craig Perkins <cwperx@amazon.com> * Mark with PublicApi Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update javadoc Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
This was referenced Jan 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small PR to update the Subject interface to use CheckedRunnable. The return value of the Callable is never used and it propagates a generic Exception which would be cleaner to get the specific exception type instead.
Related Issues
A bit of cleanup to #14630
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.