RIGHT and CENTER alignment in tabs#193
RIGHT and CENTER alignment in tabs#193ctabin wants to merge 3 commits intoopensagres:masterfrom ctabin:issue_191
Conversation
Instead of directly generating a Chunk to do the left alignment (other ones seemed to not work at all), the tab information is simply stored and used when the according text chunk is generated. See issue #191.
|
Thanks @ctabin for your PR. It's hard for me to find time to review it and your code changes a lot. Just find time to review it, sorry -( |
|
Hello @angelozerr, No problem, just tell me if you need some explanations about my changes. Best, |
|
OK, is to be reviewed or closed? I am interested as I can't even go through those changes in an easy fashion. Maybe should be just closed? |
|
@uded close it and redo a PR please. |
|
Hello @uded and @angelozerr and thanks for coming back. It makes already a long ago that I did this PR when I was testing the library to improve our PDF generation handling. And yes, at the time, a bunch of changes were required in order to solve the problem of alignment which seems to be still an open issue. Maybe you have another idea on how to fix it ? Anyway, I'm still open to help, if any need. |
3 participants
Hello,
In order to solve issue #191, I did some enhancements and refactoring in tabulation support.
Let me know if this is valuable to merge :-) Any feedback is welcomed.
Best regards,
Cédric