Conversation
sergey-lukin
force-pushed
the
master
branch
2 times, most recently
from
20dff56 to
5dcc817
Compare
|
@sergey-lukin Thanks for the patch. But will you also add some docs and tests for this new feature? Many thanks! |
| @@ -209,6 +211,16 @@ local function _encode_name(s) | |||
| return char(#s) .. s | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Style: we need 2 blank lines to separate function definitions.
|
@sergey-lukin Please rebase to the latest master branch which includes a fix for Travis CI. Also, it would be perfect if you can also add some test cases for this new feature to the existing test suite. Many thanks! |
|
Thank you for practical advises. I have fixed everything you asked except adding tests. I can do it later when I'll have some time for it. I would be grateful if you give me some help or hint about adding tests. |
|
@sergey-lukin I think you can just check out existing test cases in the https://openresty.gitbooks.io/programming-openresty/content/testing/ Thank you for your contributions! |
2 participants
No description provided.