Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
|
Looks good, I created a openrelik-common library repository. How about you move this functionality to that repo? https://github.com/openrelik/openrelik-common/blob/main/openrelik_common/telemetry.py |
src/app.py
Outdated
| # --- Tracing Setup --- | ||
| trace.set_tracer_provider(TracerProvider(resource=resource)) | ||
|
|
||
| otel_mode = os.environ.get("OTEL_MODE", "otlp-grpc") |
There was a problem hiding this comment.
Start envs with OPENRELIK_*
|
We'll get issues with the CLA thing, I'm closing this and making a new PR |
|
See #7 |
No description provided.