Skip to content
This repository was archived by the owner on Feb 14, 2026. It is now read-only.

Generate opentelemetry traces#6

Closed
rgayon wants to merge 3 commits intoopenrelik:mainfrom
rgayon:ot
Closed

Generate opentelemetry traces#6
rgayon wants to merge 3 commits intoopenrelik:mainfrom
rgayon:ot

Conversation

@rgayon
Copy link
Copy Markdown
Contributor

@rgayon rgayon commented Jul 16, 2025

No description provided.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jul 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/app.py 0.00% 23 Missing ⚠️
src/tasks.py 0.00% 7 Missing ⚠️
Files with missing lines Coverage Δ
src/tasks.py 0.00% <0.00%> (ø)
src/app.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hacktobeer hacktobeer self-requested a review July 16, 2025 18:26
@hacktobeer
Copy link
Copy Markdown
Contributor

Looks good, I created a openrelik-common library repository. How about you move this functionality to that repo?

https://github.com/openrelik/openrelik-common/blob/main/openrelik_common/telemetry.py

src/app.py Outdated
# --- Tracing Setup ---
trace.set_tracer_provider(TracerProvider(resource=resource))

otel_mode = os.environ.get("OTEL_MODE", "otlp-grpc")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start envs with OPENRELIK_*

@rgayon
Copy link
Copy Markdown
Contributor Author

rgayon commented Jul 23, 2025

We'll get issues with the CLA thing, I'm closing this and making a new PR

@rgayon rgayon closed this Jul 23, 2025
@rgayon
Copy link
Copy Markdown
Contributor Author

rgayon commented Jul 23, 2025

See #7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants