feat(plaso): allow setting a custom name for the Plaso output file#17
Open
julianghill wants to merge 3 commits intoopenrelik:mainfrom
Open
feat(plaso): allow setting a custom name for the Plaso output file#17julianghill wants to merge 3 commits intoopenrelik:mainfrom
julianghill wants to merge 3 commits intoopenrelik:mainfrom
Conversation
Contributor
|
@julianghill PTAL. Also let me know if you want to have a quick (video) call if you want that. I am Dutch as well and would be interested to hear how you folks are looking into OpenRelik: use case etc. |
c218234 to
029e026
Compare
Author
|
Thanks for the feedback @hacktobeer. I've implemented the following improvements:
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
hacktobeer
reviewed
Sep 3, 2025
Contributor
hacktobeer
left a comment
There was a problem hiding this comment.
Please take a quick look, I refactored the if/else code a bit on line 128 to make it more efficient, but let me know if this is how you had it in mind.
julianghill
commented
Sep 15, 2025
Author
julianghill
left a comment
There was a problem hiding this comment.
This works great, thanks! Sorry for the delayed response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to configure a custom name for the Plaso .plaso output file when running the openrelik-worker-plaso task.
Changes include: