Skip to content

feat(plaso): allow setting a custom name for the Plaso output file#17

Open
julianghill wants to merge 3 commits intoopenrelik:mainfrom
julianghill:feat/update-plaso-task-desc
Open

feat(plaso): allow setting a custom name for the Plaso output file#17
julianghill wants to merge 3 commits intoopenrelik:mainfrom
julianghill:feat/update-plaso-task-desc

Conversation

@julianghill
Copy link
Copy Markdown

Added the ability to configure a custom name for the Plaso .plaso output file when running the openrelik-worker-plaso task.

Changes include:

  • Added a new output_filename configuration field to the task metadata.
  • Modified the task logic to honor this field if provided by the user.
  • Preserved existing behavior by falling back to a default filename when no name is specified.
  • I hope it fits the style and let me know if any changes need to be made.

@hacktobeer hacktobeer self-requested a review July 25, 2025 08:11
Copy link
Copy Markdown
Contributor

@hacktobeer hacktobeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@hacktobeer
Copy link
Copy Markdown
Contributor

@julianghill PTAL. Also let me know if you want to have a quick (video) call if you want that. I am Dutch as well and would be interested to hear how you folks are looking into OpenRelik: use case etc.

@julianghill julianghill force-pushed the feat/update-plaso-task-desc branch from c218234 to 029e026 Compare August 26, 2025 14:50
@julianghill
Copy link
Copy Markdown
Author

Thanks for the feedback @hacktobeer. I've implemented the following improvements:

  • Replaced the .endswith(".plaso") logic with os.path.splitext() for better extension handling.
  • Multiple input files should work just fine now. Tried and tested :)

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/log2timeline.py 0.00% 13 Missing ⚠️
Files with missing lines Coverage Δ
src/log2timeline.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@hacktobeer hacktobeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a quick look, I refactored the if/else code a bit on line 128 to make it more efficient, but let me know if this is how you had it in mind.

https://github.com/openrelik/openrelik-worker-plaso/pull/17/files#diff-4f9506b47cd81a097f4b634ef0c5da891691dcde197e0f2eb7ee0359f32bcdd9R128

Copy link
Copy Markdown
Author

@julianghill julianghill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacktobeer

This works great, thanks! Sorry for the delayed response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants