Skip to content

Provide basename of file instead of full path#33

Merged
ktarasz merged 2 commits intoopenprocurement:masterfrom
selurvedu:basename
Aug 5, 2016
Merged

Provide basename of file instead of full path#33
ktarasz merged 2 commits intoopenprocurement:masterfrom
selurvedu:basename

Conversation

@selurvedu
Copy link
Contributor

@selurvedu selurvedu commented Jun 22, 2016

Also contains some minor changes in formatting and in the order of imports.

TODO before merging:

  • Add unit tests for uploading file from disk (not just from a StringIO);
  • Update robot_tests: filenames have to be compared with filenames instead of full paths.

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 72.189% when pulling c06c089 on selurvedu:basename into c97b052 on openprocurement:master.

@selurvedu
Copy link
Contributor Author

PR for task 2: openprocurement/robot_tests#251

This makes op.client upload a file with an normal filename
instead of a full file path.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 71.893% when pulling 46daadb on selurvedu:basename into 4b61ace on openprocurement:master.

@ktarasz ktarasz merged commit 8d4a58f into openprocurement:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants