Skip to content

Conversation

@Vignaudo
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the profile existence check from a POST-based API call to a GET-based one, updating both the implementation and its corresponding test. The change aligns with RESTful principles where GET requests should be used for read-only operations.

Key changes:

  • Changed the exist() method in Profile class from using POST (_call_post()) to GET (_call_get())
  • Updated the API endpoint from /profile/v1/exist/{reference} to /profile/ref?extRef={reference}
  • Modified the return logic to check HTTP status code (200) instead of parsing JSON response
  • Added type hints to MSA_API class attributes and methods for better type safety
  • Added null-safety check in check_response() method to prevent potential AttributeError

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
tests/test_profie.py Updated test to mock _call_get instead of _call_post and verify the new API endpoint format
msa_sdk/profile.py Refactored exist() method to use GET request and check status code instead of parsing JSON response
msa_sdk/msa_api.py Added type annotations for better type safety and added null-check in check_response() to handle None responses

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Vignaudo Vignaudo force-pushed the MSA-15087_getProfileByRef_ovi branch from 013b4bc to 9da2bf5 Compare December 23, 2025 09:22
@Vignaudo Vignaudo merged commit 215b946 into master Dec 23, 2025
2 checks passed
@Vignaudo Vignaudo deleted the MSA-15087_getProfileByRef_ovi branch December 23, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants