Move log into correct place for paloalto_prisma and zscaler #328
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the placement of debug log statements in two adapter classes by moving them to execute after the HTTP header list is properly initialized.
- Moved debug echo statements from before to after
$this->http_header_listassignment - Ensures the log output shows the actual configured headers instead of an uninitialized variable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| adapters/zscaler/connect.php | Moved debug log statement to print headers after they are initialized |
| adapters/paloalto_prisma/connect.php | Moved debug log statement to print headers after they are initialized |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| 'DELETE' => array('Accept: application/json'), | ||
| ), | ||
| ); | ||
| echo "connect: setting HTTP header to: " . print_r($this->http_header_list, true) . "\n"; |
There was a problem hiding this comment.
This debug echo statement should use a proper logging mechanism instead of direct output. Direct echo statements in production code can interfere with HTTP responses and API functionality.
| 'DELETE' => array('Accept: application/json'), | ||
| ), | ||
| ); | ||
| echo "connect: setting HTTP header to: " . print_r($this->http_header_list, true) . "\n"; |
There was a problem hiding this comment.
This debug echo statement should use a proper logging mechanism instead of direct output. Direct echo statements in production code can interfere with HTTP responses and API functionality.
| echo "connect: setting HTTP header to: " . print_r($this->http_header_list, true) . "\n"; | |
| error_log("connect: setting HTTP header to: " . print_r($this->http_header_list, true)); |
No description provided.