feat: dataclass implemented in openmlparameter and openmlsetup class #1582
+44
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata
OpenMLParameterto Use Dataclass #1541Details
Edited the OpenMLParameter in
openml/setups/setup.pyto use@dataclassdecorator. This significantly reduces the boilerplate code in the following places:Before:
After:
Before:
After:
Tests
For tests, I have used
xfailtemporarily to bypass the preexisting test failures intests\test_setups\test_setup_functions.py.