-
-
Notifications
You must be signed in to change notification settings - Fork 210
[ENH] Improve Global Config Architecture #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can you please add more details in your PR description? |
|
It's not ready for review yet! Hence a draft. |
|
@SimonBlanke if we make the dataclass For anyone else trying to help out, kindly refer to the issue attached to the PR (#1564) to get into the loop on the discussion. ps: Even though this is a temporary fix it seems like a good step in the right direction for having a proper config. I think I would like to add and remove a few things to build on top of this once ive a better idea though (and once this PR is closed). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
+ Coverage 79.14% 79.54% +0.39%
==========================================
Files 36 36
Lines 4320 4316 -4
==========================================
+ Hits 3419 3433 +14
+ Misses 901 883 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Metadata
OpenMLConfig.Details
What does this PR implement/fix? Explain your changes.
Refactors the configuration handling to centralize state in a single
OpenMLConfig.Why is this change necessary? What is the problem it solves?
This simplifies configuration management and makes it easier to add validation and consistency checks, avoiding scattered logic and direct mutation of module-level globals.