-
-
Notifications
You must be signed in to change notification settings - Fork 210
refactor: updated OpenMLEvaluation to use dataclass decarotor #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: updated OpenMLEvaluation to use dataclass decarotor #1559
Conversation
Signed-off-by: rohansen856 <rohansen856@gmail.com>
geetu040
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the order list, also fix the first item "Uploader Date" to "Upload Date"
openml/evaluations/evaluation.py
Outdated
| "OpenML Run URL", | ||
| "Task ID", | ||
| "OpenML Task URL" "Flow ID", | ||
| "OpenML Task URLFlow ID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "OpenML Task URLFlow ID", | |
| "OpenML Task URL", | |
| "Flow ID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohansen856 you dropped the "OpenML Flow URL" in the new commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geetu040 added the missing field and pushed the commit (12 total fields double checked).
Signed-off-by: rohansen856 <rohansen856@gmail.com>
|
@geetu040 updated the order list with required items. Ready for review! |
Signed-off-by: rohansen856 <rohansen856@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
- Coverage 79.14% 78.89% -0.25%
==========================================
Files 36 36
Lines 4320 4321 +1
==========================================
- Hits 3419 3409 -10
- Misses 901 912 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have Refactored the
OpenMLEvaluationclass from a traditional Python class to use the@dataclassdecorator to reduce boilerplate code and improve code maintainability.Metadata
OpenMLEvaluationto Use Dataclass #1540OpenMLEvaluationclass to use the@dataclassDetails
Edited the
OpenMLEvaluationclass inopenml\evaluations\evaluation.pyto use@dataclassdecorator. This significantly reduces the boilerplate code in the following places:Before:
After:
Before:
After:
All tests are passing with accordnce to the changes: