Skip to content

Conversation

@mfriesenegger
Copy link
Collaborator

The man page for os-release states: Lines beginning with "#" are treated as comments.

This PR fixes for all release file variants.

Signed-off-by: Mike Friesenegger <mikef@suse.com>
@mfriesenegger mfriesenegger force-pushed the ignore-comments-release-files branch from 7059064 to 9bd7083 Compare December 5, 2025 19:20
@mfriesenegger
Copy link
Collaborator Author

This issue was discovered because SLES 16 added comments in /etc/os-release.

@Bischoff
Copy link
Contributor

Bischoff commented Dec 6, 2025

As a side note, the handling of the antique files /etc/redhat-release, /etc/redhat-release, and /etc/system-release will disappear with the big PR to "modernize distributions".

This in turn will simplify our source code quite a lot too.

@Rajat-0 Rajat-0 merged commit 6e7c4a7 into openmainframeproject:master Dec 9, 2025
2 checks passed
@mfriesenegger mfriesenegger deleted the ignore-comments-release-files branch December 9, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants