Skip to content

Conversation

@in-manishkr
Copy link
Contributor

PR Description

This PR fixes a malformed format string in the guest_capture method.
In the current implementation, the logging statement is missing the trailing s in the format specifier, which causes a runtime exception when trying to log.

Current Code (Broken)

LOG.info("Begin to capture vm %(userid), image name is %(name)s",
         {'userid': userid, 'name': image_name})

Fixed Code

LOG.info("Begin to capture vm %(userid)s, image name is %(name)s",
         {'userid': userid, 'name': image_name})

The issue was that %(userid) is not a valid string interpolation placeholder, whereas %(userid)s is correct. This fix ensures logging works without raising exceptions.

Manish Kumar and others added 2 commits August 5, 2025 11:39
…_capture method

Signed-off-by: Manish Kumar <Manish.Kumar176@ibm.com>
@Rajat-0 Rajat-0 merged commit 430a756 into openmainframeproject:master Sep 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants