Skip to content

Conversation

@asmit27rai
Copy link

Summary

Adds support for raw-track-access mode on ECKD disks, allowing Feilong to handle:

  • Direct writing of raw track data without filesystem formatting
  • Deployment of z/OS and other non-Linux disk images
  • Existing pre-formatted ECKD disk images

Related Issues

Fixes: #714

Signed-off-by: asmit27rai <raiasmit10@gmail.com>
@asmit27rai asmit27rai force-pushed the feature/raw-track-eckd branch from 32b498b to 4871af7 Compare April 17, 2025 18:39
@asmit27rai
Copy link
Author

@Bischoff Pls review this PR

@Bischoff Bischoff requested review from Bischoff and Rajat-0 April 21, 2025 11:07
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR, but this looks to me incomplete:

  • Aren't we missing something in zvmsdk/api.py? Here:
    def image_import(self, image_name, url, image_meta, remote_host=None):
        """Import image to zvmsdk image repository

@Bischoff
Copy link
Contributor

@asmit27rai I can see you are candidate for the 2025 Linux Foundation mentorship. Be warned that candidates are selected first on their resumes, then on an online interview. Open Source contributions are not taken into account in this selection process. Don't contribute in the hope it will make you selected.

Don't misunderstand me: your contributions are really impressive, and they are much appreciated! Thank you! But if you do them, just do them for the fun, or for the sake of the project, or out of curiosity. There is no reward implied.

As an unrelated side note, I doubt you have been able to test your code. Before merging it, we would need to test it in a real mainframe testbed.

[[ $mode ]] || mode='rr'

# Ensure rawTrackAccess 1 is passed for raw mode
vmcp "link $userID $vdev as $alias $mode" 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain this line?

I don't see how rawTrackAccess is used in this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add raw-track-access mode support for ECKD

2 participants