-
Notifications
You must be signed in to change notification settings - Fork 97
Add raw-track-access mode support for ECKD disks #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add raw-track-access mode support for ECKD disks #867
Conversation
Signed-off-by: asmit27rai <raiasmit10@gmail.com>
32b498b to
4871af7
Compare
|
@Bischoff Pls review this PR |
Bischoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great PR, but this looks to me incomplete:
- Aren't we missing something in
zvmsdk/api.py? Here:
def image_import(self, image_name, url, image_meta, remote_host=None):
"""Import image to zvmsdk image repository
- Shouldn't we adapt unit tests? Like in
zvmsdk/tests/unit/test_imageops.py - Please udate documentation so the new parameter appears in https://cloudlib4zvm.readthedocs.io/en/latest/restapi.html#create-image
- and every other place I might have missed...
|
@asmit27rai I can see you are candidate for the 2025 Linux Foundation mentorship. Be warned that candidates are selected first on their resumes, then on an online interview. Open Source contributions are not taken into account in this selection process. Don't contribute in the hope it will make you selected. Don't misunderstand me: your contributions are really impressive, and they are much appreciated! Thank you! But if you do them, just do them for the fun, or for the sake of the project, or out of curiosity. There is no reward implied. As an unrelated side note, I doubt you have been able to test your code. Before merging it, we would need to test it in a real mainframe testbed. |
| [[ $mode ]] || mode='rr' | ||
|
|
||
| # Ensure rawTrackAccess 1 is passed for raw mode | ||
| vmcp "link $userID $vdev as $alias $mode" 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain this line?
I don't see how rawTrackAccess is used in this command.
Summary
Adds support for raw-track-access mode on ECKD disks, allowing Feilong to handle:
Related Issues
Fixes: #714