Skip to content

Add render for 500 errors in ExternalApiController. Make marshaller f… #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kurtnordstrom merged 1 commit into from
Oct 6, 2025
Merged

Add render for 500 errors in ExternalApiController. Make marshaller f… #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion service/grails-app/controllers/mod/rs/ExternalApiController.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ class ExternalApiController implements EventPublisher {
} catch (SAXException e){
return render(status: 400, text: "Response validation failed: ${e.message}")
} catch ( Exception e ) {
log.error("Exception receiving ISO message",e);
log.error("Exception while handling incoming ISO message",e);
return render(status: 500, text: "Error: ${e.getLocalizedMessage()}");
} finally {
log.debug("ExternalApiController::iso18626 exiting cleanly");
}
Expand Down
12 changes: 6 additions & 6 deletions service/grails-app/services/org/olf/rs/ConfirmationMessageService.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class ConfirmationMessageService {

Iso18626MessageValidationService iso18626MessageValidationService
JAXBContext context = JAXBContext.newInstance(ObjectFactory.class)
Marshaller marshaller = null

def confirmationMessageReadable(def confirmationMessage) {
StringWriter sw = new StringWriter()
Expand All @@ -25,11 +24,12 @@ class ConfirmationMessageService {
}

Marshaller getMarshaller() {
if(marshaller == null){
marshaller = context.createMarshaller()
marshaller.setProperty(Marshaller.JAXB_SCHEMA_LOCATION, Iso18626Constants.SCHEMA_LOCATION)
marshaller.setProperty("com.sun.xml.bind.namespacePrefixMapper", new IllNamespacePrefixMapper())
}
Marshaller marshaller;

marshaller = context.createMarshaller()
marshaller.setProperty(Marshaller.JAXB_SCHEMA_LOCATION, Iso18626Constants.SCHEMA_LOCATION)
marshaller.setProperty("com.sun.xml.bind.namespacePrefixMapper", new IllNamespacePrefixMapper())

return marshaller
}

Expand Down
Loading