Hide Press Manager breadcrumb from Repository Managers

src/repository/tests/test_views.py

@@ -62,6 +62,11 @@ def setUpTestData(cls):
             repository=cls.repository,
             name="Accept",
         )
+        cls.staff_user = helpers.create_user("staff@janeway.systems")
+        cls.staff_user.is_staff = True
+        cls.staff_user.is_active = True
+        cls.staff_user.save()
+        cls.repository.managers.add(cls.staff_user)
         update_settings()
 
     def setUp(self):
@@ -379,6 +384,20 @@ def test_view_preprint_comment_login_link_has_return(self):
             content = response.content.decode()
             self.assertIn("/login/?next=", content)
 
+    @override_settings(URL_CONFIG="domain")
+    def test_press_manager_link_hidden_from_repository_manager(self):
+        self.client.force_login(self.repo_manager)
+        path = reverse("preprints_manager")
+        response = self.client.get(path, SERVER_NAME=self.server_name)
+        self.assertNotIn(b"Press Manager", response.content)
+
+    @override_settings(URL_CONFIG="domain")
+    def test_press_manager_link_shown_to_staff(self):
+        self.client.force_login(self.staff_user)
+        path = reverse("preprints_manager")
+        response = self.client.get(path, SERVER_NAME=self.server_name)
+        self.assertIn(b"Press Manager", response.content)
+
 
 class TestHierarchyView(TestCase):
     """Tests for the rou_hierarchy_view introduced in iowa-and-isolinear."""

src/templates/admin/elements/breadcrumbs/repository_manager_base.html

@@ -0,0 +1,6 @@
+{% if request.user.is_staff %}<li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>{% endif %}
+{% if terminal %}
+<li>{{ request.repository.object_name|capfirst }} Manager</li>
+{% else %}
+<li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name|capfirst }} Manager</a></li>
+{% endif %}

src/templates/admin/repository/article.html

@@ -8,8 +8,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name|capfirst }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>{{ preprint.title|safe }}</li>
 {% endblock %}
 

src/templates/admin/repository/edit_authors.html

@@ -9,8 +9,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li>Edit Authors</li>
 {% endblock %}

src/templates/admin/repository/edit_metadata.html

@@ -9,8 +9,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li>Edit Metadata</li>
 {% endblock %}

src/templates/admin/repository/licenses.html

@@ -7,8 +7,7 @@
 {% block title-sub %}Management interface for {{ request.repository.name }} Licenses{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">Preprint Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>Licenses</li>
 {% endblock %}
 

src/templates/admin/repository/log.html

@@ -9,8 +9,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li>Log</li>
 {% endblock %}

src/templates/admin/repository/manage_supp_files.html

@@ -9,8 +9,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li>Manage Supplementary Files</li>
 {% endblock %}

src/templates/admin/repository/manager.html

@@ -4,8 +4,7 @@
 {% block title-sub %}Management interface for {{ request.repository.name }}{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li>{{ request.repository.object_name|capfirst }} Manager</li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" with terminal=True %}
 {% endblock %}
 
 {% load cache %}

src/templates/admin/repository/manager_comments.html

@@ -11,7 +11,7 @@
 {% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     {% if preprint %}
     {% if show_reviewed %}
     <li><a href="{% url 'repository_manager_comment_list_reviewed' %}">Reviewed Comments</a></li>

src/templates/admin/repository/notification.html

@@ -6,8 +6,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">Preprint Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li>Notification</li>
 {% endblock %}

src/templates/admin/repository/orphaned_preprints.html

@@ -6,8 +6,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">Preprint Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>Orphaned {{ request.repository.object_name_plural }}</li>
 {% endblock %}
 

src/templates/admin/repository/rejected_submissions.html

@@ -7,8 +7,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">Preprint Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>Rejected Preprints</li>
 {% endblock %}
 

src/templates/admin/repository/review/edit_review_comment.html

@@ -6,8 +6,7 @@
 {% block title-sub %}Invite a new reviewer for {{ request.repository.object_name }} #{{ preprint.pk }}{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li><a href="{% url 'repository_list_reviews' preprint.pk %}">Invited Review Comments</a></li>
     <li><a href="{% url 'repository_review_detail' preprint.pk review.pk %}">Review #{{ review.pk }}</a></li>

src/templates/admin/repository/review/list_reviews.html

@@ -7,8 +7,7 @@
 {% block title-sub %}Lists reviewers invited to comment on a preprint.{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li>Invited Review Comments</li>
 {% endblock %}

src/templates/admin/repository/review/manage_review.html

@@ -8,8 +8,7 @@
 {% block title-sub %}Invite a new reviewer for {{ request.repository.object_name }} #{{ preprint.pk }}{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li><a href="{% url 'repository_list_reviews' preprint.pk %}">Invited Review Comments</a></li>
     <li>Invite New Reviewer</li>

src/templates/admin/repository/review/manage_reviewers.html

@@ -7,8 +7,7 @@
 {% block title-sub %}Lists and manage reviewers for {{ request.repository.name }}.{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>Reviewers</li>
 {% endblock %}
 

src/templates/admin/repository/review/notify_reviewer.html

@@ -9,8 +9,7 @@
 {% block title-sub %}Send a notification to invited reviewer of {{ request.repository.object_name }} #{{ preprint.pk }}{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li><a href="{% url 'repository_list_reviews' preprint.pk %}">Invited Review Comments</a></li>
     <li>Notify Reviewer</li>

src/templates/admin/repository/review/review_detail.html

@@ -8,8 +8,7 @@
 {% block title-sub %}Details and controls for Invited Review #{{ review.pk }}{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name_plural }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li><a href="{% url 'repository_manager_article' preprint.pk %}">{{ preprint.title|safe }}</a></li>
     <li><a href="{% url 'repository_list_reviews' preprint.pk %}">Invited Review Comments</a></li>
     <li>Review #{{ review.pk }}</li>

src/templates/admin/repository/send_preprint_to_journal.html

@@ -7,8 +7,7 @@
 {% load files %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>Send Preprint to {% if journal %}{{ journal.name }}{% else %}a Journal{% endif %}</li>
 {% endblock %}
 

src/templates/admin/repository/subjects.html

@@ -7,8 +7,7 @@
 {% block title-sub %}Management interface for {{ request.press.name }} preprint subjects{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">Preprint Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>Subjects</li>
 {% endblock %}
 

src/templates/admin/repository/submission_type_form.html

@@ -10,12 +10,7 @@
 {% endblock %}
 
 {% block breadcrumbs %}
-  <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-  <li>
-    <a href="{% url 'preprints_manager' %}">
-      {{ request.repository.object_name|capfirst }} Manager
-    </a>
-  </li>
+  {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
   <li>
     <a href="{% url 'submission_type_list' %}">
       Submission Types

src/templates/admin/repository/submission_type_list.html

@@ -5,10 +5,7 @@
   Types{% endblock %}
 
 {% block breadcrumbs %}
-  <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-  <li>
-    <a href="{% url 'preprints_manager' %}">{{ request.repository.object_name|capfirst }}
-      Manager</a></li>
+  {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
   <li>{{ preprint.title|safe }}</li>
 {% endblock %}
 

src/templates/admin/repository/version_queue.html

@@ -8,8 +8,7 @@
 {% block title-sub %}There are {{ version_queue|length }} version requests for review.{% endblock %}
 
 {% block breadcrumbs %}
-    <li><a href="{% url 'core_manager_index' %}">Press Manager</a></li>
-    <li><a href="{% url 'preprints_manager' %}">{{ request.repository.object_name }} Manager</a></li>
+    {% include "admin/elements/breadcrumbs/repository_manager_base.html" %}
     <li>Version Moderation</li>
 {% endblock %}