to achieve dynamic remounting of CSI storage after a sandbox instance…#254
Open
BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
Open
to achieve dynamic remounting of CSI storage after a sandbox instance…#254BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@BH4AWS: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
zmberg
reviewed
Apr 15, 2026
| } | ||
|
|
||
| func NewSandboxControl(c client.Client, recorder record.EventRecorder, rl *RateLimiter) map[string]SandboxControl { | ||
| func NewSandboxControl(c client.Client, recorder record.EventRecorder, rl *RateLimiter, sandboxClient *clients.ClientSet, cache *sandboxcr.Cache) map[string]SandboxControl { |
Member
There was a problem hiding this comment.
use funcArgs to contain all the parameters, e.g. client, recorder.
zmberg
reviewed
Apr 15, 2026
| originObj.Annotations = make(map[string]string) | ||
| } | ||
| _, hashWithoutImageAndResource := core.HashSandbox(box) | ||
| _, hashWithoutImageAndResource := sandboxcr.HashSandbox(box) |
Member
There was a problem hiding this comment.
Move the HashSandbox to pkg/util ?
… resumes from hibernation Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
BH4AWS
force-pushed
the
feat/update_for_support_csi_mount_after_resuming
branch
from
24670c2 to
7be9446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… resumes from hibernation
Ⅰ. Describe what this PR does
1\ In order to achieve dynamic remounting of CSI storage after a sandbox instance resumes from hibernation, some shared code logic needs to be adjusted in advance. The next PR will implement CSI storage remounting after hibernation and resume based on the object-oriented approach of SandboxClaim.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews