Skip to content

Comments

8354871: Replace stack map frame type magics with constants#398

Draft
0zzy0sbourne wants to merge 1 commit intoopenjdk:masterfrom
0zzy0sbourne:JDK-8354871
Draft

8354871: Replace stack map frame type magics with constants#398
0zzy0sbourne wants to merge 1 commit intoopenjdk:masterfrom
0zzy0sbourne:JDK-8354871

Conversation

@0zzy0sbourne
Copy link

@0zzy0sbourne 0zzy0sbourne commented Dec 10, 2025

Reviewed-by: liach
Backport-of: 8a6b875


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8354871 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8354871: Replace stack map frame type magics with constants (Enhancement - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/398/head:pull/398
$ git checkout pull/398

Update a local copy of the PR:
$ git checkout pull/398
$ git pull https://git.openjdk.org/jdk25u.git pull/398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 398

View PR using the GUI difftool:
$ git pr show -t 398

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/398.diff

Reviewed-by: liach
Backport-of: 8a6b875
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 10, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

Hi @0zzy0sbourne, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user 0zzy0sbourne" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@0zzy0sbourne
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Dec 10, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@kevinrushforth
Copy link
Member

Before taking this out of Draft, change the title to make it a Backport-style PR as recommended by Skara in the Description. The title should be "Backport COMMITHASH" where "COMMITHASH" is the 40-char commit hash of the bug you are backporting.

Having said that, I believe that this PR should be redone against the jdk25u-dev repo. @GoeLin, who is the maintainer of jdk25u, can direct you.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Dec 16, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2026

@0zzy0sbourne This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants