8365579: ml64.exe is not the right assembler for Windows aarch64#349
8365579: ml64.exe is not the right assembler for Windows aarch64#349antonvoznia wants to merge 1 commit intoopenjdk:masterfrom
Conversation
Reviewed-by: jwaters, ihse, erikj
|
👋 Welcome back antonvoznia! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Hi @antonvoznia, I think you'll need to open this PR in https://github.com/openjdk/jdk25u-dev instead. |
|
Hi @swesonga , you are right, I opened a new PR, thank you! Closing this one. |
Hi,
It's a clean backport of 2 fixes:
I decided to make a single commit instead of two separate backports, since it makes sense to have both changes together.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/349/head:pull/349$ git checkout pull/349Update a local copy of the PR:
$ git checkout pull/349$ git pull https://git.openjdk.org/jdk25u.git pull/349/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 349View PR using the GUI difftool:
$ git pr show -t 349Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/349.diff
Using Webrev
Link to Webrev Comment