Skip to content

8377512: AOT cache creation fails with invalid native pointer#428

Open
antonvoznia wants to merge 4 commits intoopenjdk:masterfrom
antonvoznia:JDK-8377512-aot-cache-fails-backport
Open

8377512: AOT cache creation fails with invalid native pointer#428
antonvoznia wants to merge 4 commits intoopenjdk:masterfrom
antonvoznia:JDK-8377512-aot-cache-fails-backport

Conversation

@antonvoznia
Copy link
Copy Markdown

@antonvoznia antonvoznia commented Mar 27, 2026

It's not clean backport:

Removed
rejection_reason = "(not dumping method handles)";
rejection_reason = "(not dumping intrinsic method handles)";
JDK 25 doesn't use the rejection_reason, it requires another backport .

Function ConstantPoolCache::can_archive_resolved_method(ConstantPool* src_cp, ResolvedMethodEntry* method_entry) was a bit re-implemented, because the original fix uses logic based on "8334898: Resolve static field/method references at CDS dump time" changes within this function.

Testing:

  1. Reproducer.

  2. tests test/hotspot/jtreg/runtime/cds/appcds/aotCache/
    Without fix
    Test results: passed: 11; failed: 5; error: 1
    With fix
    Test results: passed: 15; failed: 1; error: 1

  3. OpenJDK GHA Sanity Checks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8377512 needs maintainer approval

Issue

  • JDK-8377512: AOT cache creation fails with invalid native pointer (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/428/head:pull/428
$ git checkout pull/428

Update a local copy of the PR:
$ git checkout pull/428
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 428

View PR using the GUI difftool:
$ git pr show -t 428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/428.diff

Using Webrev

Link to Webrev Comment

iklam and others added 2 commits March 27, 2026 12:10
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 27, 2026

👋 Welcome back antonvoznia! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 27, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 00c1f4b6248e116c8839b1fb19ce20182711667a 8377512: AOT cache creation fails with invalid native pointer Mar 27, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 27, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 27, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 27, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants