Skip to content

8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages#423

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8373239-V25
Open

8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages#423
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8373239-V25

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Mar 25, 2026

Backporting JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages.

This PR fixes a bug in WPrinterJob on Windows where switching from a page range selection back to "All Pages" in the print dialog failed to clear the previously set PageRanges attribute, causing the old range to persist.

For parity with Oracle JDK.

Ran related tests on windows-x64:

jtreg -jdk build/windows-x86_64-server-fastdebug/images/jdk -m test/jdk/java/awt/print/PrinterJob/PageRanges.java

Screenshot:

Screenshot 2026-03-26 at 9 14 35 AM

Result:

test result: Passed. Execution successful

PageRanges.jtr.txt

1.pdf
2.pdf


Progress

  • Change must not contain extraneous whitespace
  • JDK-8373239 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/423/head:pull/423
$ git checkout pull/423

Update a local copy of the PR:
$ git checkout pull/423
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 423

View PR using the GUI difftool:
$ git pr show -t 423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/423.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 25, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 25, 2026

@rm-gh-8 This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title Backport 1161a640abe454b47de95ed73452a78535160deb 8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages Mar 25, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 25, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 25, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 26, 2026 16:25
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 26, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Mar 26, 2026

/approval request for backport of JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages.

This PR fixes a bug in WPrinterJob on Windows where switching from a page range selection back to "All Pages" in the print dialog failed to clear the previously set PageRanges attribute, causing the old range to persist.

For parity with Oracle JDK.

Low risk — the fix is a minimal, well-scoped else branch in a Windows-only print path that restores the expected "All Pages" behavior

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 26, 2026

@rm-gh-8
8373239: The approval request has been created successfully.

@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 26, 2026

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 26, 2026
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Mar 30, 2026

Hi @rm-gh-8
please also backport the follow-up JDK-8378417 so they can be pushed together.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed ready Pull request is ready to be integrated labels Mar 30, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Mar 30, 2026

@GoeLin JDK-8378417 depends on 2 non-overlapping commits (JDK-8373239 and JDK-8363889). I was planning to merge JDK-8373239 first, then make JDK-8378417 a dependent PR of JDK-8363889. Does this strategy work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants