8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages#423
8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages#423rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change is no longer ready for integration - check the PR body for details. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages. This PR fixes a bug in WPrinterJob on Windows where switching from a page range selection back to "All Pages" in the print dialog failed to clear the previously set PageRanges attribute, causing the old range to persist. For parity with Oracle JDK. Low risk — the fix is a minimal, well-scoped else branch in a Windows-only print path that restores the expected "All Pages" behavior |
|
Hi @rm-gh-8 |
|
@GoeLin JDK-8378417 depends on 2 non-overlapping commits (JDK-8373239 and JDK-8363889). I was planning to merge JDK-8373239 first, then make JDK-8378417 a dependent PR of JDK-8363889. Does this strategy work for you? |
Backporting JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages.
This PR fixes a bug in WPrinterJob on Windows where switching from a page range selection back to "All Pages" in the print dialog failed to clear the previously set PageRanges attribute, causing the old range to persist.
For parity with Oracle JDK.
Ran related tests on windows-x64:
jtreg -jdk build/windows-x86_64-server-fastdebug/images/jdk -m test/jdk/java/awt/print/PrinterJob/PageRanges.javaScreenshot:
Result:
test result: Passed. Execution successfulPageRanges.jtr.txt
1.pdf
2.pdf
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/423/head:pull/423$ git checkout pull/423Update a local copy of the PR:
$ git checkout pull/423$ git pull https://git.openjdk.org/jdk25u-dev.git pull/423/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 423View PR using the GUI difftool:
$ git pr show -t 423Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/423.diff
Using Webrev
Link to Webrev Comment