8372710: Update ProcessBuilder/Basic regex#227
8372710: Update ProcessBuilder/Basic regex#227rudraroop wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
Hi @rudraroop, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rudraroop" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@rudraroop This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Hi,
This is a backport of JDK-8372710: Update ProcessBuilder/Basic regex
Original patch applies cleanly to jdk25u-dev
Reasoning -
The format for IOException was changed in JDK-8352533. This format change was made in openjdk25u-dev, but not updated in this test.
Background -
Originally, the fix was made in ibmruntimes/openj9-openjdk-jdk25#40 done by @theresa-m as IBM's AIX relies on this format. It was then contributed to openJDK by @Harshit470250 in JDK-8372710
Progress
Error
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/227/head:pull/227$ git checkout pull/227Update a local copy of the PR:
$ git checkout pull/227$ git pull https://git.openjdk.org/jdk25u-dev.git pull/227/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 227View PR using the GUI difftool:
$ git pr show -t 227Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/227.diff