build(scripts): use submodule commit info for reproducible builds#552
Merged
KristjanESPERANTO merged 1 commit intoopening-hours:developfrom Jan 31, 2026
Merged
Conversation
ypid
reviewed
Jan 25, 2026
Member
ypid
left a comment
ypid
left a comment
There was a problem hiding this comment.
Thanks for the prompt improvement. Looks good. I only leave minor suggestions.
KristjanESPERANTO
force-pushed
the
submoduleinfo
branch
from
d180615 to
2173fa9
Compare
HolgerJeromin
approved these changes
Jan 25, 2026
Replace non-deterministic timestamps with submodule commit hash and date for reproducible builds. The year range for holiday data is now derived from the submodule's commit timestamp instead of the current date. Ref: https://reproducible-builds.org/docs/timestamps/
KristjanESPERANTO
force-pushed
the
submoduleinfo
branch
from
2173fa9 to
2e5c5d3
Compare
HolgerJeromin
approved these changes
Jan 25, 2026
ypid
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace non-deterministic timestamps with submodule commit hash and date for reproducible builds. The year range for holiday data is now derived from the submodule's commit timestamp instead of the current date.
Ref: https://reproducible-builds.org/docs/timestamps/
As suggested here: #544