Fix installer: remove double quotes from chown and chmod executions (saiku)#49
Open
cipher-fox wants to merge 1 commit intoopenforis:masterfrom
Open
Fix installer: remove double quotes from chown and chmod executions (saiku)#49cipher-fox wants to merge 1 commit intoopenforis:masterfrom
cipher-fox wants to merge 1 commit intoopenforis:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the installer is invoked from the terminal, the
chownandchmodcommands, saiku paths were wrapped in double quotes ("), which caused issues:This PR removes the double quotes from the chown and chmod arguments so that:
In the installer, the
installdiris hardcoded as"~/OpenForis", so it is safe to remove the double quotes around the path.Error reproduced on macOS Sequoia (15.6.1 (24G90))