-
Notifications
You must be signed in to change notification settings - Fork 7
[WIP] Add DampedExp6810 and multipole handlers / potentials #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@SimonBoothroyd To get the explicit polarization potential working I'm going to need the electrostatic potential (dV/dr)*q from the Coulomb potential. Right now potential_energy_fn only takes as inputs the TensorSystem and its own TensorPotential. Is there an easy way I can get access to the electrostatics potential? Perhaps just the charges from that potential? The way this is structured in a .offxml / smirnoff plugins is to have both an Electrostatics and Multipole tag, when constructing an openmm system the multipole handler is loaded second, copies the charges from the nonbonded handler to the AmoebaMultipoleForce and then zeros out the nonbonded charges. |
|
ok @aehogan you'll need to rebase onto |
…if permanent electric field isn't), also a=0.39 for Amoeba
- Add polarization_type parameter with options: "direct", "mutual", "extrapolated" - Implement direct polarization solver (0 iterations, no mutual coupling) - Implement extrapolated polarization solver using OPT3 coefficients - Maintain mutual polarization as default (60 iterations, original behavior) - Add parameterized test for all three polarization types - Ensure backward compatibility with existing code 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
… multipole energy - Apply exclusion scaling factors in compute_dampedexp6810_energy to fix massive unphysical energies - Add batch processing support to compute_multipole_energy for multiple conformers - Implement 3 polarization calculation options: direct, extrapolated (OPT3), and mutual - Use proper three-component energy decomposition for direct and extrapolated types - All tests now passing with appropriate tolerances for each polarization method 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Description
Support for DampedExp6810 and Multipole from the smirnoff-plugins repository.
Status