204 fix py byte wrappers #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters for some functions, added Compress to binding
This was
linked to
issues
Apr 10, 2025
Closed
This was
unlinked from
issues
Apr 11, 2025
Closed
This was
linked to
issues
Apr 11, 2025
Closed
Closed
jbates-duality
approved these changes
Apr 15, 2025
Collaborator
jbates-duality
left a comment
jbates-duality
left a comment
There was a problem hiding this comment.
This all appears straightforward. On single comment on a trivial naming convention issue.
Collaborator
There was a problem hiding this comment.
In this file you did not follow the convention of other files for the macro to be prefixed and suffixed by two underscores.
Collaborator
Author
There was a problem hiding this comment.
That's correct. I have been standardizing the header file guards to follow a single convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.