Correction of an error message #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the argument mentioned in the error message for cmake when building openfhe-development for 128-bit CKKS yields the following message: Warning: Manually-specified variables were not used by the project: NATIVE_INT Looking at openfhe-development's CMakeLists.txt, the correct argument is -DNATIVE_SIZE.
ai-mannamalai
approved these changes
Feb 11, 2025
Contributor
ai-mannamalai
left a comment
ai-mannamalai
left a comment
There was a problem hiding this comment.
Seems like a reasonable change; the -DNATIVE_SIZE=128 option requires native support on the underlying processor architecture though; https://github.com/openfheorg/openfhe-development/blob/7b8346f4eac27121543e36c17237b919e03ec058/CMakeLists.txt#L278
arcturusannamalai
approved these changes
Feb 13, 2025
Collaborator
arcturusannamalai
left a comment
arcturusannamalai
left a comment
There was a problem hiding this comment.
LGTM - compile definition matches with what's in openfhe-development repo
Collaborator
|
The commit was cherry-pick'ed and pushed to the "dev" branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the argument mentioned in the error message for cmake when building openfhe-development for 128-bit CKKS yields the following message:
Looking at the current version of openfhe-development's CMakeLists.txt, the correct argument is -DNATIVE_SIZE.
https://github.com/openfheorg/openfhe-development/blob/7b8346f4eac27121543e36c17237b919e03ec058/CMakeLists.txt#L82