feat(dotnet-sdk): APIExecutor for RawRequests#676
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThese changes enable streamed list objects support in the .NET SDK by setting a configuration flag to true and add an internal property to expose the underlying ApiClient instance for custom requests without public exposure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR aims to expose the internal ApiClient for making custom API requests in the .NET SDK, but the implementation appears incomplete or misaligned with the stated purpose.
Changes:
- Adds an
internalpropertyApiClientInternalto expose the underlying ApiClient instance - Enables streaming support for list objects by changing
supportsStreamedListObjectsfromfalsetotrue
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| config/clients/dotnet/template/api.mustache | Adds internal property to expose ApiClient for custom requests |
| config/clients/dotnet/config.overrides.json | Enables streaming support for list objects |
Description
generates openfga/dotnet-sdk#176
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit