Skip to content

feat(dotnet-sdk): APIExecutor for RawRequests#676

Merged
SoulPancake merged 3 commits intomainfrom
feat/dotnet-sdk/apiexecutor-for-raw-requests
Mar 9, 2026
Merged

feat(dotnet-sdk): APIExecutor for RawRequests#676
SoulPancake merged 3 commits intomainfrom
feat/dotnet-sdk/apiexecutor-for-raw-requests

Conversation

@SoulPancake
Copy link
Copy Markdown
Member

@SoulPancake SoulPancake commented Feb 4, 2026

Description

generates openfga/dotnet-sdk#176

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • New Features
    • Enabled streaming support for list object operations in the .NET client.

@SoulPancake SoulPancake requested a review from a team as a code owner February 4, 2026 12:55
Copilot AI review requested due to automatic review settings February 4, 2026 12:55
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ac4a462-927d-4e08-848d-0f92b793ef14

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

These changes enable streamed list objects support in the .NET SDK by setting a configuration flag to true and add an internal property to expose the underlying ApiClient instance for custom requests without public exposure.

Changes

Cohort / File(s) Summary
Configuration Updates
config/clients/dotnet/config.overrides.json
Enabled streamed list objects support by changing supportsStreamedListObjects from false to true.
Template Updates
config/clients/dotnet/template/api.mustache
Added internal property ApiClientInternal that returns the underlying _apiClient instance for custom request handling without public exposure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • rhamzeh
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'APIExecutor for RawRequests' but the actual changes only include enabling streamed list objects and adding an internal ApiClient property—neither directly implements an APIExecutor. Update the title to reflect the actual changes, such as 'Enable streamed list objects and add internal ApiClient access for .NET SDK' or provide implementation matching the stated APIExecutor feature.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/dotnet-sdk/apiexecutor-for-raw-requests

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to expose the internal ApiClient for making custom API requests in the .NET SDK, but the implementation appears incomplete or misaligned with the stated purpose.

Changes:

  • Adds an internal property ApiClientInternal to expose the underlying ApiClient instance
  • Enables streaming support for list objects by changing supportsStreamedListObjects from false to true

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
config/clients/dotnet/template/api.mustache Adds internal property to expose ApiClient for custom requests
config/clients/dotnet/config.overrides.json Enables streaming support for list objects

@SoulPancake SoulPancake enabled auto-merge March 9, 2026 13:38
@SoulPancake SoulPancake added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 86bf015 Mar 9, 2026
13 of 15 checks passed
@SoulPancake SoulPancake deleted the feat/dotnet-sdk/apiexecutor-for-raw-requests branch March 9, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants