Skip to content

fix(dotnet): make Makefile respect supportsStreamedListObjects config… #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-jonathan merged 2 commits into from
Nov 19, 2025
Merged

fix(dotnet): make Makefile respect supportsStreamedListObjects config… #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8224a5f
fix(dotnet): make Makefile respect supportsStreamedListObjects config…
daniel-jonathan Nov 19, 2025
c084096
fix(dotnet): remove orphaned streaming model definitions
daniel-jonathan Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,13 @@ test-client-dotnet: build-client-dotnet build-dotnet-multi-image

.PHONY: build-client-dotnet
build-client-dotnet: build-dotnet-multi-image
make build-client-streamed sdk_language=dotnet tmpdir=${TMP_DIR} OPENAPI_GENERATOR_CLI_DOCKER_TAG=v7.11.0
@if grep -q '"supportsStreamedListObjects": true' config/clients/dotnet/config.overrides.json; then \
echo "Building dotnet SDK with streaming support..."; \
make build-client-streamed sdk_language=dotnet tmpdir=${TMP_DIR} OPENAPI_GENERATOR_CLI_DOCKER_TAG=v7.11.0; \
else \
echo "Building dotnet SDK without streaming support..."; \
make build-client-non-streamed sdk_language=dotnet tmpdir=${TMP_DIR} OPENAPI_GENERATOR_CLI_DOCKER_TAG=v7.11.0; \
fi

make run-in-docker sdk_language=dotnet image=openfga/dotnet-multi:${DOTNET_DOCKER_TAG} command="/bin/sh -c 'dotnet build --configuration Release'"
# Workaround for dotnet format issue: https://github.com/dotnet/format/issues/1634
Expand Down Expand Up @@ -199,6 +205,11 @@ build-client-streamed: build-openapi-streamed
SDK_LANGUAGE="${sdk_language}" TMP_DIR="${tmpdir}" LIBRARY_TEMPLATE="${library}"\
./scripts/build_client.sh

.PHONY: build-client-non-streamed
build-client-non-streamed: build-openapi-non-streamed
SDK_LANGUAGE="${sdk_language}" TMP_DIR="${tmpdir}" LIBRARY_TEMPLATE="${library}"\
./scripts/build_client.sh

.PHONY: build-openapi-streamed
build-openapi-streamed: init get-openapi-doc
cat "${DOCS_CACHE_DIR}/openfga.openapiv2.raw.json" | \
Expand All @@ -208,6 +219,15 @@ build-openapi-streamed: init get-openapi-doc
sed -i -e 's/#\/definitions\/Object"/#\/definitions\/FgaObject"/g' ${DOCS_CACHE_DIR}/openfga.openapiv2.json
sed -i -e 's/v1.//g' ${DOCS_CACHE_DIR}/openfga.openapiv2.json

.PHONY: build-openapi-non-streamed
build-openapi-non-streamed: init get-openapi-doc
cat "${DOCS_CACHE_DIR}/openfga.openapiv2.raw.json" | \
jq '(.. | .tags? | select(.)) |= ["OpenFga"] | (.tags? | select(.)) |= [{"name":"OpenFga"}] | del(.definitions.ReadTuplesParams, .definitions.ReadTuplesResponse, .paths."/stores/{store_id}/read-tuples", .definitions.StreamedListObjectsResponse, .definitions.StreamResultOfStreamedListObjectsResponse, .paths."/stores/{store_id}/streamed-list-objects")' > \
${DOCS_CACHE_DIR}/openfga.openapiv2.json
sed -i -e 's/"Object"/"FgaObject"/g' ${DOCS_CACHE_DIR}/openfga.openapiv2.json
sed -i -e 's/#\/definitions\/Object"/#\/definitions\/FgaObject"/g' ${DOCS_CACHE_DIR}/openfga.openapiv2.json
sed -i -e 's/v1.//g' ${DOCS_CACHE_DIR}/openfga.openapiv2.json

.PHONY: get-openapi-doc
get-openapi-doc:
mkdir -p "${DOCS_CACHE_DIR}"
Expand Down
2 changes: 1 addition & 1 deletion config/clients/dotnet/config.overrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"hashCodeBasePrimeNumber": 9661,
"hashCodeMultiplierPrimeNumber": 9923,
"openTelemetryDocumentation": "OpenTelemetry.md",
"supportsStreamedListObjects": true,
"supportsStreamedListObjects": false,
"files": {
"constants.mustache": {
"destinationFilename": "src/OpenFga.Sdk/Constants/FgaConstants.cs",
Expand Down
Loading