feat(js): use build-client-streamed for JS SDK#657
Conversation
Switch JavaScript SDK build to use build-client-streamed target (like Python SDK). This includes the streaming endpoints in the generated SDK. Changes: - Makefile: build-client-js uses build-client-streamed instead of build-client This allows the JS SDK to include StreamedListObjects endpoint while custom code in js-sdk repo (common.ts, client.ts) implements the streaming logic. Related: - openfga/js-sdk#280 - #76
WalkthroughThe Makefile's JavaScript client build recipe now invokes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)Makefile📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-09-04T17:35:34.111ZApplied to files:
📚 Learning: 2025-09-04T17:35:34.111ZApplied to files:
📚 Learning: 2025-09-04T17:35:34.111ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SoulPancake
left a comment
There was a problem hiding this comment.
LG
We can merge this after the SDK changes are merged
|
@SoulPancake sounds good. |
|
@daniel-jonathan @SoulPancake can you check if we still need build-client-streamed? Ideally, once all SDKs w/ StreamedListObjects are out we have build-client just do all the work and remoce this other target |
- Switch from build-client to build-client-streamed - Aligns with Python SDK and JS SDK (PR #657) - Includes StreamedListObjects endpoint in generated SDK - No library parameter needed (not applicable to .NET generator) Related: - openfga/dotnet-sdk#156 - #76
Great point! Once we are fully supported across the board, we won't need the separation. |
Summary
Use
build-client-streamedfor JavaScript SDK to include streaming endpoints.Changes
build-client-jsto usebuild-client-streamed(aligns with Python SDK)Related
Summary by CodeRabbit