Skip to content

chore: clarified duration syntax #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhamzeh merged 2 commits into from
Jan 16, 2025
Merged

chore: clarified duration syntax #49

rhamzeh merged 2 commits into from
Jan 16, 2025

Conversation

@aaguiarz
Copy link
Member

@aaguiarz aaguiarz commented Jan 15, 2025

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@aaguiarz aaguiarz requested a review from a team as a code owner January 15, 2025 22:07
dukex
dukex approved these changes Jan 15, 2025
View reviewed changes
Copy link

@dukex dukex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rhamzeh rhamzeh merged commit be3f80f into main Jan 16, 2025
14 checks passed
@rhamzeh rhamzeh deleted the aaguiarz-patch-1 branch January 16, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

+1 more reviewer

@dukex dukex dukex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaguiarz @dukex @rhamzeh