fix: remove reduntant & incorrect helm test#254
Conversation
|
Is there anything open which blocks this fix of being merged? The original test file was introduced here |
|
Perhaps @rhamzeh |
|
I don't have a strong argument for why this should stay, and I don't see anyone else making that argument. I'm OK with removing it for now. |
WalkthroughRemoved Helm test hook resources by deleting charts/openfga/templates/tests/test-auth-secret.yaml, which defined a test Pod and a Secret used to validate OPENFGA_AUTHN_PRESHARED_KEYS_SECRET via environment variables. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removed incorrect and redundant helm test, which does not verify correct runtime behavior of the deployment.
Description
A helm test should verify that the deployed app responds correctly. The helm test covers basic Kubernetes functionality instead.
Additionally it pulls in busybox when not really needed to the deployment when running
helm test.What problem is being solved?
Break dependency to
busybox:latestHow is it being solved?
Break dependency to busybox:latest.
Review Checklist
mainSummary by CodeRabbit